Move inline JS to regular file + other small fixes - Githubissues

openzim / openedx

Open edX (to zim) scraper

GNU General Public License v3.0

8 stars 7 forks source link

Move inline JS to regular file + other small fixes #174

Closed benoit74 closed 1 year ago

benoit74 commented 1 year ago

Rationale

Fix #168 + other small issues
Enhance logging around HTTP errors
Stop retrying HTTP errors since in most cases, the error is not transient + might lead to user ban
Replace the example course in README.md with another one in CC-BY-SA-NC (in order to avoid issues like what happened to youtube-dl)

Changes

add a Creative Commons sample EDX course
move all inline Javascript to standalone files to comply with some CSP
no more retry for login + HTTP errors
display HTTP error responses or save them in a temporary file for analysis
pin markupsafe until we upgrade Jinja2
fix issue with video that do not need to be re-encoded and were marked as missing

benoit74 commented 1 year ago

Same question as kolibri, should we release it as 1.1.0 as soon as this is merged ?