search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

support_description_long_description #183

Closed joe-rabbit closed 9 months ago

joe-rabbit commented 10 months ago

Fix #181

I have added a function called handle_descriptions that takes in three inputs: default_description, description, and long_description. It returns the description either as long_description or description. I have also made changes in the get_zim_info function.

Additionally, the newer version of make_zim_file does not take favicon as an input parameter, so I changed it to illustrations.

joe-rabbit commented 10 months ago

okay sure will make the necessary changes :)

joe-rabbit commented 10 months ago

@benoit74 ,Regarding the check, before downloading the zim file may i add the check before prepare_mooc_data() to check the ZIM_MetaData and call it again after the favicon gets downloaded ???

benoit74 commented 10 months ago

@benoit74 ,Regarding the check, before downloading the zim file may i add the check before prepare_mooc_data() to check the ZIM_MetaData and call it again after the favicon gets downloaded ???

This check must be done ASAP.

To be honest, I think you shouldn't spend too much time on this issue, the scraper is not working anymore and complex, you won't be able to really test your change. Taking an issue from youtube / ted / freecodecamp / kolibri / zimfarm would be more appropriate.

benoit74 commented 9 months ago

Closing this for now, feel free to reopen