search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Use zimscraperlib.video to transcode videos to WebM #41

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

This fixes #33 by using zimscraperlib.video module to convert to WebM

rgaudin commented 4 years ago

Good. Just version the zimscraperlib so it doesn't explode in the future. We could do same for other requirements as well.

satyamtg commented 4 years ago

Good. Just version the zimscraperlib so it doesn't explode in the future. We could do same for other requirements as well.

https://github.com/openzim/openedx/tree/refactored_project_structure - This branch actually uses a requirements.txt file with correct versions for everything. I thought we can close #37 along with #40 with that branch.

rgaudin commented 4 years ago

I don't see how that prevents us from adding the version here. That other branch doesn't even have a PR