search

openzim / openedx

Open edX (to zim) scraper
GNU General Public License v3.0
8 stars 7 forks source link

Video should be centered with 100% width in https://mooc.phzh.ch/ ZIM #73

Closed Popolechien closed 4 years ago

Popolechien commented 4 years ago

It's currently aligned to the left and smaller than 100% width that is seen in the original MOOC. Capture d’écran 2020-07-20 à 10 33 39

satyamtg commented 4 years ago

Centering the video sounds reasonable here. But, since we optimize the videos, we drop its resolution quite a bit. So, if we chose to have videos take 100% width forcefully, it would definitely make that look blurry. @rgaudin @Popolechien what are your suggestions?

rgaudin commented 4 years ago

Yes it definitely would. But only when using (--low-quality – which we'll always do). I'd lean toward keeping it as it was online, as that what the course creator expected but I don't have any other argument. It's important the course looks lean and consistent though.

Popolechien commented 4 years ago

Same here. Low quality on a very big screen would show, but a lot of use cases will be on tablets or smartphones in which case there's such a thing as too small but not too big (hopefully).

rgaudin commented 4 years ago

From the tests, only phzh has it centered.