This addresses #90 and in turn several other issues (Implements the second option as in #90). It basically gets the CSS and JS from the instance to have proper layout.
This has the following changes -
This fetches the CSS and JS from the instance at the vertical level
The CSS for the UI on our side now has prefix zim- to prevent complications with the extracted instance CSS
The CSS dependencies are now downloaded and CSS is rewritten at the CSS download step in html_processor.py
Templates are changed a bit to allow CSS to be applied properly
At this point of time it fixes #71, #72 (except fonts), #74, #80, #84
Also, with this, #78 would be a wontfix as we are only extracting CSS at the vertical level. The navigation bar can be made optional though using a parameter
82 is now fixed. It depended on a MutationObserver observing seq_contents which is not static in the instances (unlike ours). On instances they have HTMLs at sequential level whereas we have it at the vertical level. So, added a small jQuery script to simulate the sequential content change behaviour on loading a HTML.
79 is now fixed. It was due to an inline script that tried to access a tag below it. This has been solved by deferring the scripts and putting them into a separate file when they're in the body of an xblock.
Currently, the following things are yet to be solved -
Downloading fonts from imported CSS files (reason for no font fix in #72)
Having a block list for CSS/JS to not download unnecessary extras - (like there's a cookie message popping up on PHZH)
This addresses #90 and in turn several other issues (Implements the second option as in #90). It basically gets the CSS and JS from the instance to have proper layout.
This has the following changes -
zim-to prevent complications with the extracted instance CSSAt this point of time it fixes #71, #72 (except fonts), #74, #80, #84 Also, with this, #78 would be a wontfix as we are only extracting CSS at the vertical level. The navigation bar can be made optional though using a parameter
82 is now fixed. It depended on a MutationObserver observing seq_contents which is not static in the instances (unlike ours). On instances they have HTMLs at sequential level whereas we have it at the vertical level. So, added a small jQuery script to simulate the sequential content change behaviour on loading a HTML.
79 is now fixed. It was due to an inline script that tried to access a tag below it. This has been solved by deferring the scripts and putting them into a separate file when they're in the body of an xblock.
Currently, the following things are yet to be solved -