openzim / overview

:balloon: Start here for current projects, how to get involved, and joining community calls. A resource for new and veteran members of the offline commmunity
2 stars 1 forks source link

Harmonize python repos to 3.11 #13

Open rgaudin opened 1 year ago

rgaudin commented 1 year ago

For the sake of harmonization and ease of dev/maint, we want to use a single major Python version as base for all our python projects.

Following https://en.wikipedia.org/wiki/History_of_Python#Table_of_versions, we want to use 3.11 as of now. As such, support for python 3.6 (not receiving secu updates) and 3.7 (secu updates to end in 6m) will be dropped from those projects.

kelson42 commented 1 year ago

@rgaudin In an attempt to help external people to step-in, would you be able please here to give the list of concerned repositories with maybe a bullet list of points to take care?

rgaudin commented 1 year ago

Kind of the point of this ticket to figure this out.

List of repos:

What's on kiwix doesn't really fall into the python-repo category.

What I have in mind:

mgautierfr commented 1 year ago

There is kiwix-build also

kelson42 commented 1 year ago

I propose as well to use that badge PyPI - Python Version

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

benoit74 commented 7 months ago

I realize that I've probably misunderstood this PR so far; I've understood that we want to support only one single Python version (3.11 here) while it looks like the original idea was more to support a range of active versions (3.8 to 3.11 originally) and deploy (Docker) with on single version (3.11).

Should I revert some changes so that scrapers codes are still compatible with 3.8 and 3.9?

Now that Docker is mostly mainstream, I don't see a huge benefit in supporting 3 Python versions for scrapers which are mostly always "end-products", while it obviously limit what is possible with code, and since we usually have no automated tests for scrapers I'm pretty sure there will be some errors which won't be catch.

But maybe I'm too pessimistic + a bit lazy ^^

Nota: now that 3.12 is out, I'm aware we will very soon switch to 3.9 to 3.12 once scraperlib is ready

rgaudin commented 7 months ago

@benoit74 RTFM 😅

benoit74 commented 7 months ago

Thank you for your very good memory! As usual I forgot about the manual, there is just so many 🤣 Good news is that I was right in my changes (I knew it came from somewhere), latest single version is ok for scrapers, it was just not reflected in this issue (and I became worried for nothing, but I'm better safe than sorry that been said 😉)

rgaudin commented 7 months ago

Yes I think this issue predates the bootstrap and our knowledge management is organic 😉