search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
19 stars 16 forks source link

Add Python 3.11 to CI. #100

Closed FledgeXu closed 1 year ago

FledgeXu commented 1 year ago

We should add Python 3.11 tests to CI, since This lib can be run under Python 3.11 now.

kelson42 commented 1 year ago

@FledgeXu please rebase you PRs on git main branch.

rgaudin commented 1 year ago

It's already there. You are working off an out-of-date repo

FledgeXu commented 1 year ago

@rgaudin I did work off an out-of-date repo, I didn't found 3.11 in CI. https://github.com/openzim/python-scraperlib/blob/fa7b42107319dd722e1a7698931fc742d6d6d5b8/.github/workflows/ci.yml#L11-L12

rgaudin commented 1 year ago

Oh you're right ; this is called with a specific version as param. Got confused with the fact that the support is already in tox.

rgaudin commented 1 year ago

And the fact that the branch is not up to date. Please rebase and we'll merge

FledgeXu commented 1 year ago

I rebased it.