search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
18 stars 16 forks source link

Adding imaging.py and updating requirements for Nautilus compatibility #101

Closed KrishnaRishi2208 closed 1 year ago

KrishnaRishi2208 commented 1 year ago

@rgaudin I have added the required imaging.py file and updated requirements to support the pillow library which is used in imaging.py .

This will give nautilus the required functionality and allows nautilus to use scraperlib version 3.0.0 instead of the 1.1.1 version it is using.

KrishnaRishi2208 commented 1 year ago

@rgaudin I have tried to assign this PR to the issue in Nautilus, but I was unable to do that.

rgaudin commented 1 year ago

No you didn't understand. We don't want to copy a file from an old version of the library. I told you scraperlib's API changed but the feature are certainly still in scraperlib, at a different location. You just need to adapt the imports and the calls

rgaudin commented 1 year ago

And that would be in nautilus, not here!