search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
19 stars 16 forks source link

Fix return type since it is a Tuple and not a Union #105

Closed benoit74 closed 1 year ago

benoit74 commented 1 year ago

Fix #104 (wrong return type).

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (36ae903) 100.00% compared to head (200d6c2) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 32 32 Lines 1301 1302 +1 ========================================= + Hits 1301 1302 +1 ``` | [Impacted Files](https://app.codecov.io/gh/openzim/python-scraperlib/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/zimscraperlib/download.py](https://app.codecov.io/gh/openzim/python-scraperlib/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXNjcmFwZXJsaWIvZG93bmxvYWQucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.