Add support for extra zimwriterfs arguments

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers

GNU General Public License v3.0

19 stars 16 forks source link

Add support for extra zimwriterfs arguments #11

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

Fixes #10

@rgaudin I have added support for extra zimwriterfs arguments in zimscraperlib.ziim and updated the tests accordingly. The code currently passes all tests. Have a look please.

kelson42 commented 4 years ago

@satyamtg codefactor complains...

satyamtg commented 4 years ago

@satyamtg codefactor complains...

Yup. Fixed that. All local tests run fine.

rgaudin commented 4 years ago

Thank you, I've made a few minor inline comments. I think the CI is misconfigured for external PRs… I'll try to fix that. Make sure coverage stays at 100% (haven't tested yet).

satyamtg commented 4 years ago

@rgaudin did the changes and updated the test to be more robust. It should have 100% code coverage.

rgaudin commented 4 years ago

@satyamtg tank you ; can you merge the master branch in and push so I can merge this? As the tests are misconfigured, github can't do that automatically.

satyamtg commented 4 years ago

@rgaudin, okay. Doing that.