openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
18 stars 16 forks source link

Add utility function to compute/check ZIM descriptions #111

Closed benoit74 closed 10 months ago

benoit74 commented 10 months ago

Fix #110

Changes:

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f8c3cc) 100.00% compared to head (591c6dc) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #111 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 32 32 Lines 1302 1319 +17 ========================================= + Hits 1302 1319 +17 ``` | [Files Changed](https://app.codecov.io/gh/openzim/python-scraperlib/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/zimscraperlib/constants.py](https://app.codecov.io/gh/openzim/python-scraperlib/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXNjcmFwZXJsaWIvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [src/zimscraperlib/inputs.py](https://app.codecov.io/gh/openzim/python-scraperlib/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXNjcmFwZXJsaWIvaW5wdXRzLnB5) | `100.00% <100.00%> (ø)` | | | [src/zimscraperlib/zim/metadata.py](https://app.codecov.io/gh/openzim/python-scraperlib/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXNjcmFwZXJsaWIvemltL21ldGFkYXRhLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rgaudin commented 10 months ago

@benoit74 I had this stashed. Can you review this commit? Also please add your change to CHANGELOG and we'll be good to merge

benoit74 commented 10 months ago

It's ok for me, and I've added my CHANGELOG. I let you merge since I can't 😆