search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
19 stars 16 forks source link

Add support for Python 3.12 #118

Closed rgaudin closed 7 months ago

rgaudin commented 9 months ago

We are using pkg_resources which have been removed

benoit74 commented 8 months ago

Could you (again, sorry) point me to where it is used in scraperlib?

rgaudin commented 8 months ago

I can't find it!

benoit74 commented 8 months ago

CI found it for us: https://github.com/openzim/python-scraperlib/actions/runs/7802293999/job/21279404181?pr=127 🤣

The problem is in the i639 package in fact.

benoit74 commented 8 months ago

Sorry, "iso-639"

benoit74 commented 8 months ago

FYI, I'm trying a move to https://pypi.org/project/iso639-lang/ which seems maintained and supporting everything we need.

rgaudin commented 8 months ago

OK; I remember that was a petty reason to use it but I suppose if tests pass it's OK