search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
17 stars 16 forks source link

Fix alpine tests #133

Closed benoit74 closed 4 months ago

benoit74 commented 4 months ago

Fix #114 (remaining part is now tracked in #134)

Original comment

Partial fix of #114, the following test is still failing ; looks like on Alpine setlocale is never raising an error, see issue for details. I don't know if we accept to live with it or add a special detection for Alpine Linux which would skip the test.

FAILED tests/i18n/test_i18n.py::test_selocale_unsupported - Failed: DID NOT RAISE <class 'locale.Error'>

Rationale

Some tests were failing on Alpine Linux + file-magic is not well maintained / not supporting Alpine Linux

Changes

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e167913) 100.00% compared to head (68d3e30) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 32 32 Lines 1345 1345 Branches 229 229 ========================================= Hits 1345 1345 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 4 months ago

Agreed regarding the approach for finishing Alpine support: https://github.com/openzim/python-scraperlib/issues/134

benoit74 commented 4 months ago

I don't know why the CI is not trigered anymore ; may I rebase/force-push before you review the last commits?

rgaudin commented 4 months ago

I don't know why the CI is not trigered anymore ; may I rebase/force-push before you review the last commits?

Yes ; might be a GH issue ; I've had a similar pb on a different repo today

benoit74 commented 4 months ago

Force push done, CI is green, please review

benoit74 commented 4 months ago

🤦🏻