Closed benoit74 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a25ec60
) 100.00% compared to head (d180e35
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Rationale
StringProvider
supports bothbytes
andstr
types ascontent
butStaticItem
accepted onlystr
in its type hintadd_item_for
to use newStaticItem
parametersmain
code on kolibri showed an issue when the content passed toadd_item_for
/StaticItem
is an empty string "" ; content is not set andStaticItem
fails to know which content provider has to be usedChanges
bytes
andstr
types ascontent
inStaticItem
bytes
andstr
types ascontent
in scraperlibStringProvider
StringProvider
disable_metadata_checks