Closed benoit74 closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
b479038
) to head (d18275c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nota: this has already been tested locally to work fine with ted scraper
I was just filling a gap, since it was intentional I will remove this right now.
Change done and first comment updated to reflect the new PR content.
Arf, I added two args to fill the gap and you made two remarks, so I misread them as being linked to these two args. I did not realized your first remark was about the workaround_nocancel
which was already there before this PR. Let's discuss it live to be sure we are aligned
After discussion:
workaround_nocancel
as-isignore_duplicates
which is always True (not exposed)After some thought, I think that we have to expose ignore_duplicates
, someone very cautious in his scraper could run a deduplication on the files before calling make_zim_file
, add needed redirects / aliases after that, and expect the libzim to stop if it detects a duplicate.
👍 ; as long as it defaults to True :)
But someone cautious would not be using the zimwriterfs mode 😅
Does your 👍 means you've reviewed this PR and I can merge or that you've approved my proposition?
Yes
Changes
disable_metadata_checks
,ignore_duplicates
andarguments incompression
make_zim_file
function ("zimwritefs-mode")disable_metadata_checks
when adding this functionality ... while it is the first (and maybe even main) use case ...ignore_duplicates
inmake_zim_file
function ("zimwritefs-mode")True
, since it most cases this is what we want (we usually do not run a deduplication function before-hand on files stored in the filesystemI intend to release this as 3.3.2 as soon as it is merged since we want to proceed with TED upgrade to benefit from new encoder presets.