search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
19 stars 16 forks source link

Use lxml parser with BeautifulSoup #51

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

This fixes #50 by using LXML parser with BeautifulSoup while rewriting links.

codecov[bot] commented 4 years ago

Codecov Report

Merging #51 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #51   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          798       798           
=========================================
  Hits           798       798
Impacted Files Coverage Δ
src/zimscraperlib/zim/rewriting.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f479f0c...c34d42c. Read the comment docs.

rgaudin commented 4 years ago

maybe use a range for the deep