openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
18 stars 16 forks source link

Fix rewriting of links with empty target #54

Closed satyamtg closed 3 years ago

satyamtg commented 3 years ago

This fixes #53 by correctly rewriting of links with empty target. Also adds a test for the same.

codecov[bot] commented 3 years ago

Codecov Report

Merging #54 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          798       798           
=========================================
  Hits           798       798           
Impacted Files Coverage Δ
src/zimscraperlib/zim/rewriting.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75a3829...431df5a. Read the comment docs.