search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
18 stars 16 forks source link

Add wait parameter in YoutubeDownloader.download() #62

Closed satyamtg closed 3 years ago

satyamtg commented 3 years ago

This fixes #61 by adding a wait parameter in YoutubeDownloader.download() which allows to disable waiting for the completion of the current job and return a Future object in that case. The usage in the tests is also fixed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #62 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          974       976    +2     
=========================================
+ Hits           974       976    +2
Impacted Files Coverage Δ
src/zimscraperlib/download.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b65da9...2b44bdd. Read the comment docs.