search

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers
GNU General Public License v3.0
18 stars 16 forks source link

Add high quality presets for WebM and Mp4 encoding #66

Closed satyamtg closed 3 years ago

satyamtg commented 3 years ago

This adds two new presets for high quality WebM and Mp4 encoding. These are VideoWebmHigh and VideoMp4High. Both use constant quality mode using -cbr and it is set to a value where we get quality similar to the source and a similar filesize too, The lower the value of -cbr, the higher the quality and the higher the filesize.

codecov[bot] commented 3 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          976       982    +6     
=========================================
+ Hits           976       982    +6
Impacted Files Coverage Δ
src/zimscraperlib/video/presets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1949552...f11e250. Read the comment docs.

rgaudin commented 3 years ago

Looks good. Can you add that comment about -cbr in the code and rebase?

satyamtg commented 3 years ago

Looks good. Can you add that comment about -cbr in the code and rebase?

Did that