Make paths more generic

openzim / python-scraperlib

Collection of Python code to re-use across Python-based scrapers

GNU General Public License v3.0

19 stars 16 forks source link

Make paths more generic #9

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

This makes the fix_ogvjs_dist.py more generic by adding functionality as mentioned in issue #1 . @rgaudin @kelson42 please suggest changes/improvements.

Fixes #1

rgaudin commented 4 years ago

Thanks. Please fix the codefactor and ask for a request when you're ready

satyamtg commented 4 years ago

Hey @rgaudin , have fixed it. Should work now. Please have a look.

satyamtg commented 4 years ago

Did a quick fix and ran all tests. I am not going to propose even a single line of untested code. It works now and I've tried to keep the code as short as possible. Also, I did wanted to Request for review previously but I cannot assign any reviewer (GitHub won't let me for this repo). I can only re-request.