search

openzim / sotoki

StackExchange websites to ZIM scraper
https://library.kiwix.org/?category=stack_exchange
GNU General Public License v3.0
216 stars 25 forks source link

Style is slightly broken #270

Open rgaudin opened 1 year ago

rgaudin commented 1 year ago

Most likely due to an update of upstream's styles, sotoki UI doesn't render as it should.

Before

Screen Shot 2022-07-26 at 09 26 03

Now

Screen Shot 2022-07-26 at 09 25 44

This most likely affects all websites, but maybe in different ways

theparthshukla commented 1 year ago

Happy to take this up on the off-chance this hasn't been fixed already.

rgaudin commented 1 year ago

It has not ; feel free to submit a PR

theparthshukla commented 1 year ago

@rgaudin Unable to reproduce the bug by generating a zim and opening with Kiwix off the main branch on a Mac. Am I missing something?

rgaudin commented 1 year ago

Ah! Indeed latest version on the library (2022-11) isn't broken anymore.

Thanks for testing!

kelson42 commented 1 year ago

@rgaudin Does that work out of the box, or should we make a new release to benefit of it?

rgaudin commented 1 year ago

Nothing to do. We retrieve styles from SO website.

rgaudin commented 1 year ago

@theparthshukla I still get it when running sotoki. Tried with beer.stackexchange.com, beer.meta.stackexchange and conlang.stackexchange

rgaudin commented 1 year ago
Screenshot 2023-03-06 at 13 17 27
theparthshukla commented 1 year ago

@rgaudin which reader are you using? I'll try reproducing the bug again

rgaudin commented 1 year ago

Kiwix-serve (main)

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

MUCCHU commented 7 months ago

I would love to contribute to this issue, if no one's already working on it.

rgaudin commented 7 months ago

It's yours

aryamanan commented 6 months ago

Can I be assigned with this issue in case the issue still persists?