openzim / sotoki

StackExchange websites to ZIM scraper
https://library.kiwix.org/?category=stack_exchange
GNU General Public License v3.0
217 stars 25 forks source link

Fix the bug of the metadata of the multi-language site. #280

Closed FledgeXu closed 1 year ago

FledgeXu commented 1 year ago

Fix: #259

kelson42 commented 1 year ago

@rgaudin We should check the Name metadata as well

FledgeXu commented 1 year ago

@kelson42 So far, the value of the Name metadata is the file name.

kelson42 commented 1 year ago

@FledgeXu … and it’s wrong. For the SE about French language for example:

Can you please fix these problems as well please?

FledgeXu commented 1 year ago

@kelson42 I just check the Name metadata, it looks right?

image
FledgeXu commented 1 year ago

I just update the code for the clear logic.

FledgeXu commented 1 year ago

@rgaudin Thanks for your reviews! Although it's not merged, I still learnt a lot.