openzim / ted

Provide the best of TED.com for offline usage!
https://download.kiwix.org/zim/ted/
GNU General Public License v3.0
13 stars 9 forks source link

Always reencode videos and allow to choose quality preset #160

Open benoit74 opened 8 months ago

benoit74 commented 8 months ago

The scraper always re-encode with the low quality preset if the --low-quality setting is used or if the requested video format is not the same as the one used by TED.

I would have expected the scraper to reuse TED video if format is same, and re-encode with high or low preset depending on the --low-quality preset (so that we can re-encode in "high-quality").

Is this intentional?

rgaudin commented 8 months ago

I think the question is malformed but I'll rephrase was we intended:

The main reason is to harmonize the quality of videos within a ZIM file. It's possible that the collections of videos to include are widely different in terms of quality/filesize/dimensions. re-encoding would help.

We can revisit (this choice dates back a few years) or we can extend the options to allow bundling source video.

benoit74 commented 8 months ago

Then the scraper is not working as intended (and I like what was intended).