Closed benoit74 closed 3 months ago
Nota : CI is failing for now, we need to wait for merge + release of https://github.com/openzim/python-scraperlib/pull/147
Attention: Patch coverage is 0%
with 46 lines
in your changes are missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
8451330
) to head (dde529e
).:exclamation: Current head dde529e differs from pull request most recent head 1ab9caf. Consider uploading reports for the commit 1ab9caf to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The primary goal of this PR was to upgrade to zimscraperlib 3.x to benefit from VideoLowWebm preset v2.
However, while working on it, it became clear that other things had to be fixed / where low hanging fruits.
This PR will probably induce a v3 of the scraper, the fact that we now check metadata by default is clearly a breaking change.
Make some progress on #145 Fix #169 Fix #152 Fix #148
Changes