openzim / ted

Provide the best of TED.com for offline usage!
https://download.kiwix.org/zim/ted/
GNU General Public License v3.0
13 stars 8 forks source link

Upgrade dependencies especially zimscraperlib 3.x #170

Closed benoit74 closed 3 months ago

benoit74 commented 3 months ago

The primary goal of this PR was to upgrade to zimscraperlib 3.x to benefit from VideoLowWebm preset v2.

However, while working on it, it became clear that other things had to be fixed / where low hanging fruits.

This PR will probably induce a v3 of the scraper, the fact that we now check metadata by default is clearly a breaking change.

Make some progress on #145 Fix #169 Fix #152 Fix #148

Changes

benoit74 commented 3 months ago

Nota : CI is failing for now, we need to wait for merge + release of https://github.com/openzim/python-scraperlib/pull/147

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8451330) to head (dde529e).

:exclamation: Current head dde529e differs from pull request most recent head 1ab9caf. Consider uploading reports for the commit 1ab9caf to get more accurate results

Files Patch % Lines
src/ted2zim/scraper.py 0.00% 32 Missing :warning:
src/ted2zim/multi/scraper.py 0.00% 5 Missing :warning:
src/ted2zim/processing.py 0.00% 5 Missing :warning:
src/ted2zim/entrypoint.py 0.00% 2 Missing :warning:
src/ted2zim/multi/entrypoint.py 0.00% 1 Missing :warning:
src/ted2zim/utils.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 7 7 Lines 984 1013 +29 Branches 229 215 -14 ===================================== - Misses 984 1013 +29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.