Populate the real list of languages in ZIM metadata

openzim / ted

Provide the best of TED.com for offline usage!

https://download.kiwix.org/zim/ted/

GNU General Public License v3.0

13 stars 8 forks source link

Populate the real list of languages in ZIM metadata #181

Closed benoit74 closed 2 months ago

benoit74 commented 2 months ago

Rationale

Fix #172

Changes

moved all lang related functions to languages.py
added few tests for existing conversion from input languages to TED code
added new function to convert back TED code to ISO639-3 code
added code to compute ZIM languages (twice, asap to avoid downloading videos if we know there is a metadata issue and later once the final list of downloaded videos is known)
better handle case when opening the video page with the lang queryparameter not set

benoit74 commented 2 months ago

I had to rebase the branch so that conflict is gone.

You should do your second review with only last 3 commits, 4th one is not changed, just rebased: https://github.com/openzim/ted/pull/181/files/13de099f8fd4b53753e0150313f02e6a54b63796..HEAD

Note the last commit which is something new, I just experienced a bug in the ZIM UI when displaying a video without and lang query parameter set (don't know exactly why, but it happened to me ... probably when there is only one language in the ZIM)

benoit74 commented 2 months ago

don't know exactly why, but it happened to me ... probably when there is only one language in the ZIM

I got it, in fact kiwix-serve removes the lang query parameter in the URL displayed in the browser, so if you just reuse the same link, the lang query parameter is gone and UI was broken (no title, no description displayed at all)