openzim / ted

Provide the best of TED.com for offline usage!
https://download.kiwix.org/zim/ted/
GNU General Public License v3.0
13 stars 8 forks source link

Translation of video title and description is not working on PWA reader #188

Open benoit74 opened 2 months ago

benoit74 commented 2 months ago

Scraper version: 3.0.0 ("release candidate")

ZIM File: https://mirror.download.kiwix.org/zim/.hidden/dev/ted_mul_pain_2024-04.zim

Library: https://dev.library.kiwix.org/viewer#ted_mul_pain_2024-04

PWA version: 3.1.8

How to reproduce:

On kiwix-serve, you can directly navigate to such a translate page, e.g. https://dev.library.kiwix.org/content/ted_mul_pain_2024-04/how-to-deal-with-rejection?lang=fr

@Jaifroid I'm not sure this is something to fix on scraper side or on PWA side, could you please advise?

The scraper is injecting JS code which detects dynamically the URL param which is passed (e.g. fr in https://dev.library.kiwix.org/content/ted_mul_pain_2024-04/how-to-deal-with-rejection?lang=fr). Code is based on JQuery, and I find pretty hackish tbh: https://github.com/openzim/ted/blob/main/src/ted2zim/templates/assets/article.js. I hope we will be able to fully rewrite this sooner than latter (but it is probably going to be latter).

benoit74 commented 1 week ago

This will be solved with a proper implementation of #208