search

openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
44 stars 4 forks source link

Zimit2: do we need to set extra_opts for max bitrate of Twitter / Vimeo videos? #161

Open benoit74 opened 7 months ago

benoit74 commented 7 months ago

See https://github.com/openzim/warc2zim/pull/158#discussion_r1467770641 for details.

kelson42 commented 7 months ago

Is that critical for Zimit 2.0 release success?

kelson42 commented 3 months ago

Here I would like to better understand what is the point from user perspective? Do we have a clear problem right now?

benoit74 commented 3 months ago

Problem is around Twitter and Vimeo videos, but it is not well defined and we don't know if it has a real user impact or not.

What we know is that wabac has some specific code which rewrites Twitter and Vimeo video player code to tweak some stuff. For now, this has been only partially backported to warc2zim codebase, and this might cause issues with Vimeo and Twitter videos.

We did not yet dig much into Twitter and Vimeo videos since it was deemed to not be a priority. But if wabac had to do these player code rewrites, there is little chance it is not needed in warc2zim as well.