openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
44 stars 4 forks source link

Zimit2: add support for JS importmap #230

Open benoit74 opened 5 months ago

benoit74 commented 5 months ago

Upstream issue in wombat probably has to be fixed first, see https://github.com/webrecorder/wombat/issues/141

Once wombat is fixed, it will probably work straight out of the box (i.e. we will just have to update wombat version in openzim.toml)

kelson42 commented 3 months ago

Not sure what is the status now considering upstream issue has been closed without PR.

benoit74 commented 3 months ago

As mentioned in upstream issue, Ilya considers this is not something to solve in wombat but in wabac (already done) and warc2zim (still to do). I'm not sure I agree with this because I haven't had enough resources to dive in the issue, but he is probably right (but I feel it a bit awkward, I don't get why these importmap references - not targets - needs to be rewritten, they are supposed to be only identifiers). Anyway, still not solved in warc2zim for sure.