openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
41 stars 5 forks source link

base href is not properly handled for notification of JS modules #250

Closed benoit74 closed 1 month ago

benoit74 commented 1 month ago

JS code is already properly rewritten when a base href is configured in the HTML document, but the notification system used to know which JS file is a module is not properly taking into account the base href from the HTML document.

For JS modules, the base href of HTML document must be taken into account to properly notify of the module location (both in external script and when using inline JS module).

benoit74 commented 1 month ago

Fixed by https://github.com/openzim/warc2zim/pull/251