search

openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
45 stars 4 forks source link

Move from multiple `--tags` flags to one single `--tags` flag #265

Closed benoit74 closed 6 months ago

benoit74 commented 6 months ago

Currently, when the user wants to specify multiple ZIM tags, he has to specify multiple time the --tag parameter like in warc2zim --tags "Quality Assurance" --tags "Another TAG"

This kind of thing is not supported by the Zimfarm and is not in line with other scrapers behavior.

We hence want to move to one single --tags flag which might contain a CSV value like in warc2zim --tags "Quality Assurance,Another TAG". Commas are not expected to be used in tag values.

NOTA: this is a breaking API change ... so better done in 2.0.0

benoit74 commented 6 months ago

See https://github.com/openzim/warc2zim/pull/267#discussion_r1611585140, values must be separated by semicolons.

kelson42 commented 6 months ago

Seems to be fixed!