Closed benoit74 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.38%. Comparing base (
1cffd0a
) to head (a8c5232
).:exclamation: Current head a8c5232 differs from pull request most recent head f946842
Please upload reports for the commit f946842 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I dont think I can be of much help here but the problem description is too vague IMO.
trailing characters are not removed in Javascript
Good point, I added an example in first comment.
While fuzzy rule is working well in Python, trailing characters after the
?
from the querystring are not removed in Javascript causing the fuzzy rewriting to be incorrect.E.g.
'i.ytimg.com/vi/-KpLmsAR23I/maxresdefault.jpg?sqp=-oaymwEmCIAKENAF8quKqQMa8AEB-AH-CYAC0AWKAgwIABABGHIgTyg-MA8=&rs=AOn4CLDr-FmDmP3aCsD84l48ygBmkwHg-g
is transformed intoi.ytimg.com.fuzzy.replayweb.page/vi/-KpLmsAR23I/thumbnail.jpgsqp=-oaymwEmCIAKENAF8quKqQMa8AEB-AH-CYAC0AWKAgwIABABGHIgTyg-MA8=&rs=AOn4CLDr-FmDmP3aCsD84l48ygBmkwHg-g
instead ofi.ytimg.com.fuzzy.replayweb.page/vi/-KpLmsAR23I/thumbnail.jpg
This PR fixes the situation by updating the fuzzy rules and adding a minimal test set in Javascript.
Long term solution to test all fuzzy rules in JS is described in #284