Closed benoit74 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.72%. Comparing base (
94c6900
) to head (2e68138
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I honestly have no idea. This comes at least from wombat, but I strongly suspect it comes from the Youtube player itself which is setting the src
of the image to an object instead of a String
for some reason. Tests have shown it is indeed working once converted to a String, and value is really correct, so this value is "mostly" a string (otherwise the image won't load anyway) but has not yet been converted.
I'm not totally satisfied either, but since this is also specific to one kind of reader, I propose to merge as-is for now, and we will diagnose once we are bitten again (which I suppose won't happen, but I'm well aware I might be wrong)
In some occasions, url passed to JS rewriting function is an object instead of a string, causing problems like https://github.com/openzim/zim-requests/issues/1011#issuecomment-2135505415