openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
40 stars 5 forks source link

Do not indicate to wombat that we are running inside a SW since we are not #294

Closed benoit74 closed 5 days ago

benoit74 commented 1 month ago

This is a draft PR because while it allow to solve the problem in #293, it breaks youtube videos (and probably other things)

I don't really get yet why we used to indicate to wombat that we are running inside a Service Worker since we are not.

Git history is not very clear, and this was one of the undocumented option indicated to be solved in https://github.com/openzim/warc2zim/issues/239 ; @mgautierfr do you have any explanation to share?

I tested this with all test cases from the test website and they seems to all responded positively except the Youtube video.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.72%. Comparing base (0219021) to head (49bb914).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ======================================= Coverage 83.72% 83.72% ======================================= Files 13 13 Lines 1223 1223 Branches 232 232 ======================================= Hits 1024 1024 Misses 153 153 Partials 46 46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 3 weeks ago

do you have any explanation to share?

Not really. Some mix of copy/paste and "it was working". BTW, I don't know what is the real impact on wombat when we set (or not) this config option.

Jaifroid commented 3 weeks ago

Speculation: The Replay Worker could be run either as a Service Worker or as a Web Worker. Is it possible that some URLs would be rewritten differently if they were intended to be caught by a Service Worker as opposed to being "sent" to a regular Worker?

benoit74 commented 5 days ago

Superseeded by #334