search

openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
40 stars 5 forks source link

Drop `integrity` attribute in `<script>` HTML tags #298

Closed benoit74 closed 3 weeks ago

benoit74 commented 3 weeks ago

See https://github.com/openzim/zim-requests/issues/1025

We cannot click on the navigation tree on the left (at least, it does not expand / collapse sections properly).

Broken ZIM is available at https://dev.library.kiwix.org/viewer#dart.dev_en_all_2024-06

benoit74 commented 3 weeks ago

It looks like we have at least a problem linked to the "integrity" attribute of the <script> tag loading some JS code. Might well explain the issue.

benoit74 commented 3 weeks ago

Removing the integrity attribute in script tags is indeed sufficient to fix dart.dev homepage.

I propose to drop this attribute in <script> tags since this is probably sufficient, at least for now.

kelson42 commented 3 weeks ago

I should learn what the "integrity" attribute is about first...

kelson42 commented 3 weeks ago

@benoit74 Following documentation https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity you might remove it from "link" nodes as well?!