openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
40 stars 5 forks source link

Detect content type based on WARC-Resource-Type #306

Closed benoit74 closed 2 weeks ago

benoit74 commented 2 weeks ago

Fix #296

Nota: this PR is slightly enhanced compared to what has been proposed in the issue due to some stuff that has been realized during implementation

Changes:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.01%. Comparing base (24aeafa) to head (92a456f).

Files Patch % Lines
src/warc2zim/content_rewriting/generic.py 76.00% 3 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================== - Coverage 84.17% 84.01% -0.17% ========================================== Files 14 14 Lines 1245 1270 +25 Branches 240 249 +9 ========================================== + Hits 1048 1067 +19 - Misses 152 155 +3 - Partials 45 48 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 2 weeks ago

Issues around code coverage are not new. They are now properly tracked in #307 and #308.