Closed benoit74 closed 2 weeks ago
Attention: Patch coverage is 76.00000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 84.01%. Comparing base (
24aeafa
) to head (92a456f
).
Files | Patch % | Lines |
---|---|---|
src/warc2zim/content_rewriting/generic.py | 76.00% | 3 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues around code coverage are not new. They are now properly tracked in #307 and #308.
Fix #296
Nota: this PR is slightly enhanced compared to what has been proposed in the issue due to some stuff that has been realized during implementation
Changes:
WARC-Resource-Type
header when available inside the WARC to decide what kind of content / rewrite we haveWARC-Resource-Type
is not guaranteed to be present inside the WARC, for old WARC but also for WARC created with other tools then Browsertrix crawler