Closed benoit74 closed 3 months ago
Attention: Patch coverage is 93.75000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 84.49%. Comparing base (
4c12681
) to head (9933304
).:exclamation: Current head 9933304 differs from pull request most recent head b1c8a35
Please upload reports for the commit b1c8a35 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/warc2zim/utils.py | 91.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
CodeFactor is complaining about files which should be ignored since they are outside our scope, these are sample files from online websites.
Can you add exceptions then? Either inline, via a config file or via Codefactor UI
Can we rename guessed_charsets with charsets_to_try ?
Sure
Good luck with Codefactor 😀
I will kill it ^^ It worked once, I supposed my last modification was ok so I cleaned up everything I've left over, it's not working anymore, I rolled-back to what was working, it is not working anymore. But I will nail it ^^
Codefactor issues its configuration from main
branch, so you have to merge first to main
before you can review the PR ...
Go ahead
@benoit74 Bravo... and bon courage!
Go ahead
I already pushed only the configuration to main branch. My comment was more for "the posterity". I still have to rewrite this branch to change arg name + simplify commits.
Bravo... and bon courage!
We will finish by nailing this down ^^
Fix #312
Changes
or UTF-16 or UTF-32
is a slight change compared to issue proposal because with UTF-16 and UTF-32 first bytes cannot be decoded to ascii properly (they always use at least 16 bytes or 32 bytes even for ascii characters)