openzim / warc2zim

Command line tool to convert a file in the WARC format to a file in the ZIM format
https://pypi.org/project/warc2zim/
GNU General Public License v3.0
40 stars 5 forks source link

Add option to ignore charsets found automatically #319

Closed benoit74 closed 1 week ago

benoit74 commented 1 week ago

Fix #318

Changes:

benoit74 commented 1 week ago

Nota: tested successfully on www.bouquineux.com

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.61%. Comparing base (4abf952) to head (dd9c878).

:exclamation: Current head dd9c878 differs from pull request most recent head e68a5bf

Please upload reports for the commit e68a5bf to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #319 +/- ## ========================================== + Coverage 84.49% 84.61% +0.12% ========================================== Files 14 14 Lines 1238 1248 +10 Branches 245 246 +1 ========================================== + Hits 1046 1056 +10 Misses 149 149 Partials 43 43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 1 week ago

Sorry, I committed and pushed to the wrong branch. I reset the PR as it was when review was requested, sorry for that.

benoit74 commented 1 week ago

Hope we won't end up with a cli option per recipe 😉

That's a good question, it is not the last CLI option I plan to add 😉 But flying an A380 is not like flying a Piper, you need a bit more controls ^^