search

openzim / wp1

Wikipedia 1.0 engine & selection tools
https://wp1.openzim.org
GNU General Public License v2.0
24 stars 17 forks source link

Upgrade Python version to 3.9 #290

Closed audiodude closed 3 years ago

audiodude commented 3 years ago

This should simply be a matter of running the Python tests and assuring they pass, then updating the documentation, CI, and the Docker images.

DiyaReddy commented 3 years ago

@audiodude Hello,i would like to try this issue. so do we need to convert the existing files into python 3.9 and make them run on the latest version? and update all the documents , CI and Docker images?

abdulmoiz37 commented 3 years ago

Hello @audiodude.I am Looking to Submit the Proposal in GSOC Through Kiwix.org. I Would Like to Contribute to this issue. can i Work on this issue or is someone else Working?

audiodude commented 3 years ago

@audiodude Hello,i would like to try this issue. so do we need to convert the existing files into python 3.9 and make them run on the latest version? and update all the documents , CI and Docker images?

There shouldn't be any code changes necessary. If there are, they will be exposed through running the tests. As the issue says, it's mostly a matter of updating docs, CI and the Docker images.

Hello @audiodude.I am Looking to Submit the Proposal in GSOC Through Kiwix.org. I Would Like to Contribute to this issue. can i Work on this issue or is someone else Working?

@abdulmoiz37 I believe @DiyaReddy was first in line, sorry. There are other issues in the repo you could look at.

abdulmoiz37 commented 3 years ago

@audiodude Hello,i would like to try this issue. so do we need to convert the existing files into python 3.9 and make them run on the latest version? and update all the documents , CI and Docker images?

There shouldn't be any code changes necessary. If there are, they will be exposed through running the tests. As the issue says, it's mostly a matter of updating docs, CI and the Docker images.

Hello @audiodude.I am Looking to Submit the Proposal in GSOC Through Kiwix.org. I Would Like to Contribute to this issue. can i Work on this issue or is someone else Working?

@abdulmoiz37 I believe @DiyaReddy was first in line, sorry. There are other issues in the repo you could look at.

Okay @audiodude :)

audiodude commented 3 years ago

@mahakporwal02 Do you want to take this one?

mahakporwal02 commented 3 years ago

@mahakporwal02 Do you want to take this one?

Yes, thanks.

DiyaReddy commented 3 years ago

I have tested all the files 575 tests run successfully!

On 22-Apr-2021, at 12:37 AM, mahakporwal02 @.***> wrote:

 @mahakporwal02 Do you want to take this one?

Yes, thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mahakporwal02 commented 3 years ago

@DiyaReddy I checked there are only 209 tests in CI. Am I missing something?

DiyaReddy commented 3 years ago

Yes, and I have tested tests from the source too that is the reasons the count is more!

Sent from my iPhone

On 22-Apr-2021, at 3:36 PM, mahakporwal02 @.***> wrote:

 @DiyaReddy I checked there are only 209 tests in CI. Am I missing something?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.