Open kelson42 opened 3 weeks ago
This is a git repository. All patches are in form of commits in git history. But anyway, I will soon write a resume of the status about compilation on Windows, probably on kiwix-build side.
@mgautierfr We should not have the Xapian source code here. I'm very concerned as this breaks our internal rules and best practices, which leads to a serious maintainability challenge. Any reason why these patches are not applied as patch on the original source code (to be downloaded)?
Current situation should be understood as temporary and goal is to remove this source code. As such, the required issues should be open here so we can track each of this modification/patches, or modification groups. One per issue. For each issue, a PR should be made upstream to request the change or a justification should be given to keep it.
Current situation should be understood as temporary and goal is to remove this source code.
We agree on that
Any reason why these patches are not applied as patch on the original source code (to be downloaded)?
Because we are in a temporary (Work in Progress) situation and we want to track the evolution of the patches applied. Having a temporary repository with all added file versionned on top of xapian source code is really simpler
For each issue, a PR should be made upstream to request the change or a justification should be given to keep it.
90% of the current commit are about meson compilation only. Some patched has been already applied upstream (and this also why we are based on git upstream and not on released version which doesn't contain such patches) If not send upstream, it is mainly because of priority issue.
@mgautierfr It's important that - before your absence - that:
Situation is more or less clean, ie. no Xapian source codes and proper unit patches applied. It should have been like this for the very beginning.
I disagree with you.
Here are the things I want to see followed:
I understand that this is a work in progress but:
The approach (modifying directly the source code) like you made, can perfectly be needed at early stage, but keep in mind that this can be on your local system or personal repository, but this is not the level of quality expected in official Kiwix repositories.
I wanted to create a repository on my personal account but you ask to have it in openzim organization...
I propose the following:
Is it ok for you ?
How do we get the list of patches appied to Xapian source code?
Considering we should not have to patch the source code to compile it, each patche should be clearly identified and a strategy to bring it upstream shoukd be available.