search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
53 stars 29 forks source link

Channel/User/Playlist input checking #109

Closed satyamtg closed 3 years ago

satyamtg commented 4 years ago

https://farm.openzim.org/pipeline/5ef9ad429ec57a810576f6e7/debug failed with an error - 

OSError: [Errno 36] File name too long: '/tmp/tmphtp8ytv7/cache/channel_PLr5n3ojAJWjSVnG_EK1xF3rW1Lo0N2qwA,PLr5n3ojAJWjQEiRIuHlRoN7rBDKG6GbvH,PLr5n3ojAJWjRGQ1DnnIqDrIXKuuNydGid,PLr5n3ojAJWjTkqDW49ew1u7vsbVzM5Uub,PLr5n3ojAJWjSVh9mgusLb6npGNnFif_Sw,PLr5n3ojAJWjRSuu4s5Vu1CEN0rkgXZ-VA,PLr5n3ojAJWjRDmRmIVAsD4MSEt7wMSOGr,PLr5n3ojAJWjSNVp6jrlwXPz5MyFArv6oO,PLr5n3ojAJWjRiuPrUAAveWrrqnNPPNzYK.json'

This is due to the JSON name being the same as the --id tag it seems.

rgaudin commented 4 years ago

This is an incorrect recipe. Recipe states that this is a channel and provides a list of playlists as ID.

The auto-name/filename feature constructs a name/filename based on the channel ID which, in this case, is incredibly long and incorrect.

Channels are usually 24chars long, so we should exit and warn should a user launch a channel request with an ID longer than that but that's just for usability improvements.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

DevanshD3 commented 4 years ago

Hey I am new to open source community , could you please explain the issue ? I didn't quite understand it

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.