Use newer multithreaded youtube downloader from scraperlib

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist

GNU General Public License v3.0

39 stars 26 forks source link

Use newer multithreaded youtube downloader from scraperlib #118

Open satyamtg opened 3 years ago

satyamtg commented 3 years ago

We now have support for downloadeing youtube videos on a fixed number of threads in scraperlib. Hence, we shall use that instead of the current approach of downloading in batches

rgaudin commented 3 years ago

We definitely should but we shall keep an alternative method for S3 download/upload (IO bound) and ffmpeg (cpu bound)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 1 month ago

@benoit74 Still a valid issue? Or maybe already fixed in 2.3.0?

benoit74 commented 1 month ago

If I get it correctly, this is still not implemented:

goal of this issue is to use https://github.com/openzim/python-scraperlib/blob/7d498319baadba715316c15cf9857ff2f6974a00/src/zimscraperlib/download.py#L18C7-L18C24
currently downloads are still not done with it: https://github.com/openzim/youtube/blob/main/scraper/src/youtube2zim/scraper.py#L739-L740

benoit74 commented 3 weeks ago

Let's focus on new UI for 3.0