search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
43 stars 26 forks source link

WebP polyfill error on welcome poster #128

Closed rgaudin closed 2 years ago

rgaudin commented 3 years ago

At least on skin-of-color-society the welcome poster is not displayed.

Multiple refresh might trigger the following error message and/or make the poster appear. This tend to point to a loading issue. It may be that we're calling the polyfill too early after the code that injects the video details on top and (more importantly) the videojs call that transforms this node into the video player.

[Error] Unhandled Promise Rejection: e: webp image polyfill failed for url "http://localhost:9999/skin-of-color-society_en_all_2020-10/I/videos/lDgUCN4IuY0/video.webp": e: failed to polyfill image "http://localhost:9999/skin-of-color-society_en_all_2020-10/I/videos/lDgUCN4IuY0/video.webp": failed to decode webp image: undefined is not an object (evaluating 'o.asm.stackSave')
    (anonymous function) (webp-hero.bundle.js:1:985679)
    (anonymous function) (webp-hero.bundle.js:1:985719)
    s (webp-hero.bundle.js:1:984479)
    promiseReactionJob
stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

gajanangitte commented 3 years ago

the CHANGELOG showed some fixes made to WebP for apple poly-filling. is this issue still open to work on? would it be solved if we delay the trigger_web_polyfill function by a second? please guide me on this issue

kelson42 commented 3 years ago

AFAIK the issue is still valid but the rootcause is unknown, you should try by yourself a solution.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 2 years ago

@rgaudin Considering that now all modern Web browsers support Webp image format:

I wonder if we should keep this ticket open?

rgaudin commented 2 years ago

I suppose we've gained more experience on this with later scrapers and we could adapt our fixes to youtube but we might as well close this. Your call