search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
46 stars 26 forks source link

Video viewer should allow change of reading speed #174

Closed Popolechien closed 3 months ago

Popolechien commented 1 year ago

Many players allows their users to modify the video reading speed, either more slowly to ease comprehension or faster for speed-viewing (e.g. 0.75x - 1.25x)

benoit74 commented 3 months ago

https://github.com/openzim/youtube/pull/229 suggests to propose 0.25, 0.5, 1, 1.5, 2 as reading speeds in ; @dan-niles could you explain why you chose these values?

@Popolechien these are the reading speed that will be available in the video player, is that ok for you?

dan-niles commented 3 months ago

I just wanted to make it more similar to what YouTube offers, ranging from 0.25x to 2x.

Additionally YouTube also provides 0.75x and 1.75x, so I can also include those if needed. So the playback rates would be: [0.25, 0.5, 0.75, 1, 1.5, 1.75, 2]

Popolechien commented 3 months ago

7 different speeds? Seems a lot to me but who are we to question their choices ¯_(ツ)_/¯

benoit74 commented 3 months ago

Then we are all OK to keep only 5 choices?

Popolechien commented 3 months ago

Yeah Netflix has 0.5x, 0.75x, 1x, 1.25x, 1.5x (5 choices). Since #229 is in the pipe already I think it fits well enough.

benoit74 commented 3 months ago

OK, so let's use 0.25, 0.5, 1, 1.5, 2 for now, and we'll see if this is a problem.