search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #175

Closed benoit74 closed 1 month ago

benoit74 commented 11 months ago

See https://github.com/openzim/overview/issues/21

dikshant182004 commented 10 months ago

I hope this message finds you well. I'm Dikshant jha and I am eager to contribute to this open-source issue. After reading the project and its documentation, I think this can be the right fit as a potential task to work on as my first contribution.

I am new to open-source contributions, and I would greatly appreciate your mentorship and guidance as I get started. If you have some time, could we schedule a brief chat or exchange messages to discuss this further? I'm eager to learn and contribute to the project's success.

Thank you for considering my request. I look forward to your response

benoit74 commented 10 months ago

Thank you @dikshant182004 for your proposition to help. I will contact you on Slack, it will be easier to discuss there.

dikshant182004 commented 10 months ago

okay, Let's discuss on slack

benoit74 commented 9 months ago

We must also update Jinja2 at the same time, and get rid of markupsafe explicit version.

benoit74 commented 9 months ago

And check if if not isinstance(html, str): in render_template is still needed.

benoit74 commented 8 months ago

And upgrade to Python 3.11 (or 3.12 if zimscraperlib has been updated to support it)

benoit74 commented 7 months ago

Cannot be done before https://github.com/openzim/youtube/issues/186 is solved. Otherwise, many zimfarm recipe will fail due to invalid metadata.

benoit74 commented 7 months ago

Cannot be done before https://github.com/openzim/youtube/issues/147 in fact (#186 is a duplicate).