Closed benoit74 closed 11 months ago
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
I just uploaded https://dev.library.kiwix.org/viewer#badminton_webm_2023-10/home.html which has been created by this new code.
I would like to test this on IE11 / old Safari to ensure there is no regression since I updated the webp polyfill, but I probably do not have it at home.
* ⚠️ Trusted publishing must be setup on this repo
Added
I think I've provided feedback on remaining points.
Fix #180
Changes:
load_mandatory_json
util function which raises an error if file is not present or JSON is not valid (instead of returning None)render_template
util function which returns a string or returns an error (to circumvent various types returned by Jinja)