Closed benoit74 closed 8 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
a0e0300
) 1.83% compared to head (bd67bbb
) 1.83%.
Files | Patch % | Lines |
---|---|---|
src/youtube2zim/playlists/scraper.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I propose to ignore codecov warning, since the file is not covered at all anyway.
I just fixed the PR title which was wrong indeed.
Rationale
main
status since this would solve #184 (which is blocking all scrapers) but:metadata_from
when running the scraper withyoutube2zim-playlists
; it is obviously harmless to simply disable this code since it is not possible to setup themetadata_from
which current code anywaymain
is in fact not correct, it is using Python 3.11 while we are still atzimscraperlib
2.0 which supports only Python 3.10 (don't know why this is not causing a problem in Docker build + why it does not raised a red flag before)Changes
metadata_from
to always beNone
for nowzimscraperlib
version constraints in hatch dependencies with project version (just in case)