search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

update: added a simple workaround for setup issues #190

Closed jo780-full closed 6 months ago

jo780-full commented 6 months ago

This is a simple work around for #189. Following the installation process in the current README.md ,all the required assets aren't built. For instance ,there is an error that states video-ovjs.js file is not availble in the tmp/templates/assets folder I have had to build them separately and copy them into the library file within my virtual environment.

This PR contains the required steps for the same.But this is not an ideal fix, considering the user uses pip3 to install the library packages. This is only an interim change; the fix should be to build the dependencies while installing youtube2zim from pip

benoit74 commented 6 months ago

This has been fixed by https://github.com/openzim/youtube/commit/26f5c712a49ebe7cbffe2cc2e8ad597ff9ea99dc indeed