search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

update: added a simple workaround for setup issues #191

Closed jo780-full closed 1 month ago

jo780-full commented 6 months ago

FIX #175 Hi @benoit74 , This is the first version of the changes , I still need to add the validation of metadata check before the scraper starts the downloading process. However, I have made a few changes that makes the scraper compatible with the new version of the zimscraper library.I have some doubts regarding the validation process, I have messaged regarding the same.

benoit74 commented 6 months ago

Hi, I will review the PR only once the code is ready to be merged. Here your PR does not change anything. I moved the PR to Draft for now.

If you have concerns that need to be discussed, please ask questions here (or in the issue) so that they can be discussed in open.

jo780-full commented 5 months ago

@benoit74 , i added checks for ASAP in the scraper.py by calling validate_metadata(). Kindly do check and let me know,sorry it took a while because I had some other hold up :)

jo780-full commented 5 months ago

Sure, Ill try working on it. Thanks for the feedback

benoit74 commented 1 month ago

Closing this, it has been staled for weeks and similar work is now mostly ready to be merged in #202 (and I'm sure it will be merged in the coming days)