search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

Harmonize default publisher to `openZIM` #192

Closed benoit74 closed 4 months ago

benoit74 commented 6 months ago

As required in https://github.com/openzim/zim-requests/issues/779, the default ZIM publisher must be openZIM (mind the case)

nida-imran173 commented 4 months ago

@benoit74 Should all instances of default publisher be changed from 'Kiwix' to 'openZIM' in scraper.py?

benoit74 commented 4 months ago

I expect to have only one default value in entrypoint.py and this should make its way to the ZIM. I don't know why there are so many default publisher values in scraper.py, they should probably be removed. And you should check that the publisher from entrypoint.py is passed to the ZIM, default value or customized one with a CLI flag.

nida-imran173 commented 4 months ago

So basically, the idea is to set only the default publisher value in entrypoint.py for consistency across the project. Correct?

benoit74 commented 4 months ago

Yep