openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

Update default publisher to 'openZIM' #195

Closed nida-imran173 closed 4 months ago

nida-imran173 commented 4 months ago

Description

This pull request updates the default publisher from "Kiwix" to "openZIM" in src\youtube2zim\entrypoint.py file.

Changes Made

nida-imran173 commented 4 months ago

I apologize for the oversight. I will start the scraper to ensure it is still functioning properly. I'll provide you with an update on the results shortly. Can you kindly elaborate on "and hence we must remove all other default values."

benoit74 commented 4 months ago

Can you kindly elaborate on "and hence we must remove all other default values."

I do not want to have any "openZIM" or "Kiwix" string anywhere else in the codebase, it should be present only in entrypoint.py (in code only, I do not mind about documentation, ...) ^^

nida-imran173 commented 4 months ago

To proceed, we could consider removing None from the publisher parameter value and replacing default values with self.publisher throughout the codebase. I'd like to hear your thoughts before proceeding with the implementation.

benoit74 commented 4 months ago

To proceed, we could consider removing None from the publisher parameter value and replacing default values with self.publisher throughout the codebase. I'd like to hear your thoughts before proceeding with the implementation.

I don't get it, why not just removing all default values, meaning the parameter has to be passed? Period. This would not work?

benoit74 commented 4 months ago

Edit: all but the one from entrypoint.py, of course

nida-imran173 commented 4 months ago

I don't get it, why not just removing all default values, meaning the parameter has to be passed? Period. This would not work?

yes

nida-imran173 commented 4 months ago

@benoit74 I have made some additional changes to our existing pull request. Please review these modifications and confirm if they meet our expectations.